Ped Damage Overhaul 2.0 BETA 7

2 hours ago, lexo1000 said:

Thanks! Also is it possible to make horse less resistant to bullets? Actually my horse never die in gunfights and make  horse reviver pointless.

There is already a HorseHealth option in the ini. We are currently looking into core drain for horses, maybe we'll have something for the next release.

So if I set HorseHealth = 50, does it mean that my horse will have 50% of its normal health? Or it will set its health to 50 points, regardless of its breed?

Also please could you make CoreDepletionAfterDeath = 1 only occur when dying while free roaming and not after die and retry a mission?

13 hours ago, lexo1000 said:

So if I set HorseHealth = 50, does it mean that my horse will have 50% of its normal health? Or it will set its health to 50 points, regardless of its breed?

Also please could you make CoreDepletionAfterDeath = 1 only occur when dying while free roaming and not after die and retry a mission?

Its a fixed health value, independent of the breed.

Ok thanks. A percentage would be better in order to keep the benefit of catching or buying strongest horses.

@HughJanus
Ive tried to configure a mix between vanilla euphoria npc behavior (more cineastic npc movement when shot) and the dying movement on the ground.
My intention was to configure a clean motion pass over from vanilla stumbling and movement (until the npc is on the ground) to the dying movement mode of the mod.
I wanted to prevent the knock back (KnockbackChance) and the euphoria ballancer of the mod (DSEuphoriaStumbleChance) which let the npc walk in a random direction or causing a simple fall to the ground.

With my current .ini configuration i did a good progress and sometimes it is working well but often there are some problems which i dont know how to solve...

Problem:
When i shoot a npc, the vanilla euphoria kicks in and the npc starts to stumble and behave (touching bullet holes and so on)... after a few more shots, the vanilla bullet force is suddenly gone and the npc starts to stand still (while getting shot)... if i stop shooting, the npc will collapse after 1 - 2 seconds, if i continue shooting, no force will applied to the npcs body but after 1 or 2 seconds, the bullet force is insane and sends the npc flying...

Desired behavior:
In this case, everything works fine! The npc is in dying mode after vanilla euphoria ragdoll behavior brings the npc to the ground... This is the desired behavior without Knockback or DSEuphoriaStumble!

Issues:
This is the case, where the vanilla bullet force is getting lower and lower until its completely gone and the npc is standing still:

In this cases the last bullet sends the npc flying:

Questions:
It seems like the vanilla euphoria sequence break when the NPCs health crosses the dying mode threshold and causes these strange behaviors (with still standing and so on...)
What do i have to configure to bring the NPC in dying mode right AFTER he allready feld to the ground after vanilla euphoria is done? (like in the first video)
Is it possible to only activate the dying mode SPECIFIC when the npc is laying on the ground? Maybe by checking coordinates of specific bones?
If not, is it possible to activate a kind of "delay" (of the dyning mode) which kicks in when the NPCs health is under the dyning mode threshold to prevent the breaking of the vanilla euphoria ragdoll?

Here the values which i changed in the ini:

KnockbackThreshold = 0

KnockbackChance = 0

DSEuphoriaStumbleChance = 0

DSMaxStumbleTime = 0

DSMaxEuphTime = 3000

;stumbling
BothLegsStumbleForcePushX = 0
BothLegsStumbleForcePushY = 0
BothLegsStumbleForcePushZ = 0
OneLegStumbleForcePushX = 0
OneLegStumbleForcePushY = 0
OneLegStumbleForcePushZ = 0
IsDirectionRelativeOneLeg = 0
IsForceRelativeOneLeg = 1
IsDirectionRelativeBothLegs = 0
IsForceRelativeBothLegs = 1

DyingPushChance = 0
DyingForcePushX = 0
DyingForcePushY = 0
DyingForcePushZ = 0

HeadVecMaxTime = 0 (intention: to mimize the "still standing time" of the npc)

Thanks for your help and keep up the good work of that great mod!

@AnymYo Try playing with DSEuphTime and DSDelay - those in combination with the HeadVec-values (delta and time) create the shock state. But if you dont want any altered euphoria behavior, I suggest setting DSEuphTime to a low value like 0, 10 or 100 and then work up from there. If that doesnt result in anything you want, you can try tweaking DSDelay. HeadVecMaxTime I would set to something higher than 0 (like 100 or so) - if you want the head bone check to stop, I would rather increase the range of the delta value than lower the one for the time check.

Hi HughJanus 

In previous versions, when NPCs were falling down, they writhed in pain for few seconds and then die (which was really nice to see 😉 Now most of the time they falling down and simply stay on the ground without moving at all and then die. Is there any way to make this animation happens more often by editing the .ini?
Thanks in advance.

@HughJanus Thanks, i will try to configure these values and test the result.

@lexo1000
If you dont mean the vanilla "injured on ground" euphoria behavior, this could help you.
Open the .ini file from PDO version 1.56 and go down to line 39 - 48.
There should be the following values:

Quote

;DyingMovementThreshold is the health threshold under which NPCs wont be able to get back up again when knocked down (still moving on the ground) - if DyingMovment is disabled (in the advanced section),
;the behavior under this threshold is the same as for the DyingThreshold
DyingMovementThreshold = 70

;DyingMovementThreshold2 is the health threshold under which NPCs wont be able to get back up again when knocked down (still moving on the ground, less agile than the first threshold) - if DyingMovment is
;disabled (in the advanced section), the behavior under this threshold is the same as for the DyingThreshold
DyingMovementThreshold2 = 50

;DyingThreshold is the health threshold under which NPCs wont be able to get back up again when knocked down (just lying on the ground, not moving)
DyingThreshold = 25

Turn down the values from DyingMovementThreshold2 and DyingThreshold. That should bring the desired effect that downed npcs moving on the ground more agile.
For example like this:

Quote

;DyingMovementThreshold is the health threshold under which NPCs wont be able to get back up again when knocked down (still moving on the ground) - if DyingMovment is disabled (in the advanced section),
;the behavior under this threshold is the same as for the DyingThreshold
DyingMovementThreshold = 70

;DyingMovementThreshold2 is the health threshold under which NPCs wont be able to get back up again when knocked down (still moving on the ground, less agile than the first threshold) - if DyingMovment is
;disabled (in the advanced section), the behavior under this threshold is the same as for the DyingThreshold
DyingMovementThreshold2 = 5

;DyingThreshold is the health threshold under which NPCs wont be able to get back up again when knocked down (just lying on the ground, not moving)
DyingThreshold = 3

If the NPCs health is 70 or less but over 5, the NPC will move on the ground.

@AnymYo Please post your settings if you manage to fix that weird shock state/bad standing. You'd save a lot of people I'm sure of it. Thanks :D

It wasn't aware to us that the shock state was such a problem for some of you.

We'll take a look at it for the next release.

To add on from lexo's comment, I've been having the issue with NPC's dying after really short falls for some time. When they hit the ground, first they lay there for a moment, then they stagger and grunt, then they lay there for another moment, then they die. A great place to test this is Valentine, lots of small elevated ledges like the saloon's entrance, if you grapple an NPC and throw them off you'll see it happen quite a lot. At first I chocked it up to being an issue with my custom ini configuration but it's still happening after a fresh install to the latest version of the mod.

However, I found a brute force fix. It was FallTime that was causing it I believe, for some reason the millisecond timer keeps going a little bit after they've hit the floor (I think, but i'm guestimating), not sure if this is a thing with the mod or the game itself, but I was able to give that issue a fix by doubling the default values below. Now NPC's don't die when they fall like 2 feet. I'm sure there are more precise values that can be put in-place of that though. 

Quote

;FallTimeDown is the time in milliseconds an NPC has to be falling to be incapacitated afterwards
FallTimeDown = 1100

;FallTimeDeath is the time in milliseconds an NPC has to be falling to be dead afterwards
FallTimeDeath = 2500

@HughJanus @foxy9911
I tried anything but could not deactivate the shock state. I can reduce the shock time but at the end, the vanilla euphoria sequence will break, the npc will walk slower and slower until hes standing for a second and than collapse... Especialy with the lemat revolver the shock state is nearly to 100% happening.
I also noticed, that the shock state is using the configured advance stumbling values (line 319 to 328 [or 336]) even when DSEuphoriaStumbleChance, DSMaxStumbleTime, DSDelay and DSMaxEuphTime set to 0. Is this working properly so or is it a bug?

DSEuphoriaStumbleChance is a nice feature but IMHO sometimes it looks a little bit strange if the npcs walking every time in a circle and dont react to bullets like a few seconds before... this could be related to the differend "ragdoll and balance" behavior which will applied on the NPC if this mechanic kicks in (it is the same behavior that is used for the shock state i guess). This behavior makes the npc more lifeless (no bullet wounds touching, no reaction to body shots, no bullet force, only balancing if a force push will be applied) and breaks the immersion a little bit.

If i understand correctly, the shock state behavior kicks in, when the NPCs health is under the value from DyingMovementThreshold  (standart 70). If this happens while the npc is ragdolling, the vanilla euphoria breaks and the shock state behavior kicks in. So the only way to prevent this is disabling the Dying movement (which kills almost the complete mod kommt also absolut nicht in Frage 😄 )

Currently:
1. You shoot a NPC (Health is 100, threshold is 70)
2. The NPC is pushed away from the bullet force (sadly this is like RDR2 and also GTA5 works cause no NaturalMotion developers are involved in R* game production anymore sience shitty Zynga baught NaturalMotion)
3. While the NPC is stunbling in vanilla euphoria ragdoll (but not on the ground) the NPC health crosses the threshold of 70 and the shock state kicks in. <- here is the (more or less) problem
4. The NPC dont react to bullets anymore and falls to the ground using the "Knockback" sequence or (if you continue shooting) is going to fly because suddenly bullets are insanely powerfull.

The problem might be to find a way to get the NPCs in a dynamic way to the ground (in case that the threshold is crossed but the NPC wont fall down after stumbling) which wont breake the current motion sequence and let the NPC still reacting to the environment and bullets. Maybe by calling the vanilla "writhed in pain euphoria" sequence (I mean the movement of the last 1 second which a NPC is performing right after you killed him on the ground finaly). In GTA 5 this physics task should be called "CTaskNMInjuredOnGround". The taskname should be the same in RDR2. This could force a standing NPC in a "dynamic vanilla euphoria like" way to the ground and prevents the use of a force (X,Y,Z) which would push the NPC in a specific (everytime the same) direction repetitive again and again like the DSEuphoriaStumbleChance feature. The new mechanic should always match the situation.

Some friendly suggestions for future releases:
- A (additional) mechanic which activates the dying mode (shock state) only if the NPC lays on the ground (maybe by checking the position of specific bones) with a time delay option to prevent the "vanilla euphoria sequence breaking" (in case of a NPC is going down but the force causes the NPC to roll on the ground for 1 or 2 meters but the NPC health is under DyingMovementThreshold, the delay option would prevent the break of the current motion sequence and would activate the "shock state on ground" mode after a certain amount of time later).

- An option to configure the bullet impact force which is applied on NPCs. Some weapons sends NPCs flying.

Beste Mod die es bisher gibt, weiter so!

@AnymYo Thanks for the input. Some of your suggestions are already part of the mod, others will not have the effect you would wish for, I fear. Let me explain how things currently work, so we can have a little discussion about what to do:

General

The mod constantly iterates through all the NPCs loaded by the game.

For each NPC a whole lot of checks and actions are applied.

Each NPC has a flag for activated DyingStates and one for activated EuphoriaStumbling (EuphoriaStumbling only applies to those with DyingStates enabled).

The percentage chances (DyingStateChance, DSEuphoriaStumbleChance) is the percentage for each NPC to get flagged (when first appearing in the game - the flag is then permanent for this NPC).

Specific ("dying mode" = DyingStates)

NPCs can be in normal task mode (they walk, talk, do whatever) or in ragdoll. Unfortunately there is no way of checking if an NPC is currently using euphoria behavior - no matter if an NPC is "just" a ragdoll or currently euphoria ragdolling, the game always returns "true" if you ask if the NPC is in ragdoll. This is the main problem, because you are not able to find out whether an NPC is still reacting to something or already ragdolling completely. So here is the current solution for this problem:

• If an NPC has its health below the DyingMovementThreshold and is in ragdoll for the first time since crossing the threshold, the NPC is flagged ("is in DS ragdoll").
• The mod waits for the time set in DSMaxEuphTime an then checks if the flagged NPC is still in ragdoll. If not, nothing happens and the game begins again (waiting for next ragdoll) --> this allows NPCs to flinch or react without being forced into permanent ragdoll.
• If after DSMaxEuphTime the NPC is still in ragdoll, it gets permanently ragdolled, but with the "try to balance ragdoll" (to be sure the NPC goes to the ground at some time).
• After the NPC has entered the "try to balance ragdoll" the mod waits for the time specified in DSDelay. When this has passed, the NPC is checked for whether its head is high enough (between ZValueForHeadBone and ZValueForHeadBone2 --> this should mean that the NPC is still standing). If the NPC is still standing, the force pushes are applied (DyingPushChance, DyingForcePushX, DyingForcePushY, DyingForcePushZ) until the NPCs head is lower than ZValueForHeadBone (= on the ground).
• Also, as a security measure if the NPC is being force-pushed around and not going down, after the DSDelay the counter for DSMaxStumbleTime starts. If the NPC is still in being pushed and trying to balance mode, after DSMaxStumbleTime has passed, it gets forced to the ground.

Notice that when EuphoriaStumbling is not enabled for the NPC, the whole pushing and balancing thing does not happen - the NPC will get forced to the ground instead of pushed around. Forcing to the ground always happens via the "ragdoll force fall" native function.

The shock state happens when NPCs are in ragdoll for too long (DSMaxEuphTime is passed) but not moving in any specific direction, so the "try to balance ragdoll" keeps them standing still. To circumvent that, we implemented HeadVecMaxDelta and HeadVecMaxTime:

• If an NPC is in ragdoll, the position of the NPCs head gets stored and the HeadVecMaxTime counter starts.
• If after the counter has passed, the NPCs head is still within the HeadVecMaxDelta, the NPC gets forced to the ground via pushing (ragdoll force fall looked extremely weird, so we decided to push).

HeadVecMaxDelta gets applied to all axis (positive and negative). The check looks like this:

if (*NPC is standing*) *do HEAD_CHECK*

HEAD_CHECK:
if ((headpre.x < headpost.x + delta && headpre.x > headpost.x - delta) ||
  	(headpre.y < headpost.y + delta && headpre.y > headpost.y - delta) ||
  	(headpre.z < headpost.z + delta && headpre.z > headpost.z - delta))
  {
  	*push NPC*
  }

The shock state was usually there for a long time (without the head check with time and delta).

After implementing this and configuring it, the shock state now only lasts for a few seconds.

We were fine with the results and left it that way (thinking users could "configure it away" if they wanted to).

But since you tried to do so unsuccessfully, we might have to take a look at the code.

I am the only one actively coding, so this will be my task :P

Since I have very little spare time on my hands, please dont expect miracles.

I am always open to input, though. So if you have an idea, please share. I havent really discussed or thought of any solution before, because I didnt think it was a problem.

Since the v1.56 release, I have been only working on some performance fixes - so if you have any suggestions, I will try them next time I sit in front of my Visual Studio.

@Zere.exe the solution with the fall time was tested quite a bit, so I am surprised there was such a major bug (also no one has reported this one ever (not even on nexus)). Glad that you could work it out.

I have to admit, however, that I dont exactly know how long an NPC counts as "is falling" in the game engine. Our tests could never provide precise results.

@HughJanus that's very strange, I've tried multiple fresh installs of the mod from the Nexus upload to beta versions on here and that one keeps coming up for me (I spend a lot of time in Valentine fist fighting so I noticed it every time I'd play), the only other mod I have that could be considered gameplay altering is 'Rampage Trainer' but I have no idea if that could be causing the bug. I'll keep my eye out and see if anything similar crops up in other areas of the game, hopefully nobody else runs into it, but if they do, increasing the FallTimeDeath has definitely fixed it for me. I've been playing with that altered setting and the bug hasn't come up since.

Also just out of curiosity as I haven't spotted anything in the config about it, is it possible to change the force/distance applied to a ped when you throw/dismiss them after grappling? Just a little something I was thinking of playing around with if it can be done.

2 hours ago, Zere.exe said:

@HughJanus that's very strange, I've tried multiple fresh installs of the mod from the Nexus upload to beta versions on here and that one keeps coming up for me (I spend a lot of time in Valentine fist fighting so I noticed it every time I'd play), the only other mod I have that could be considered gameplay altering is 'Rampage Trainer' but I have no idea if that could be causing the bug. I'll keep my eye out and see if anything similar crops up in other areas of the game, hopefully nobody else runs into it, but if they do, increasing the FallTimeDeath has definitely fixed it for me. I've been playing with that altered setting and the bug hasn't come up since.

 

Also just out of curiosity as I haven't spotted anything in the config about it, is it possible to change the force/distance applied to a ped when you throw/dismiss them after grappling? Just a little something I was thinking of playing around with if it can be done.

I wrote the problem down and we will test it in the next releases testing phase.

Concerning the throwing force, there is nothing you can alter at the moment.

Alrighty, thanks

Hey janus I love messing around in the ini and I was wondering why it's only when the npc is totally on ground that the bleeding kicks in, if a npc kinda slump into some crates or something in a akward position he won't start bleeding but if I push his body until mostly of his body is in contact with the ground that when he starts bleeding, I read above about the head delta, it's that it that I need to tweek or is some other value?

@Wicker During un-modded gameplay I would not eat that often and had the problem of Arthur losing weight. This problem I dont have anymore since now Im forced to eat. Getting overweight is probably a matter of the core draining interval (configurable via the ini file) - as it is set now in the default overhaul ini, I have not had any problems with Arthur gaining weight.

@ChristianW. What exactly do you mean by "bleeding"?

33 minutes ago, HughJanus said:

@Wicker During un-modded gameplay I would not eat that often and had the problem of Arthur losing weight. This problem I dont have anymore since now Im forced to eat. Getting overweight is probably a matter of the core draining interval (configurable via the ini file) - as it is set now in the default overhaul ini, I have not had any problems with Arthur gaining weight.

 

@ChristianW. What exactly do you mean by "bleeding"?

I mean losing health you know, when they lose points until dying, if they drop in a weird position they don't die, but if a push the body to a flat plane that's when the bleeding kicks in

4 hours ago, ChristianW. said:

I mean losing health you know, when they lose points until dying, if they drop in a weird position they don't die, but if a push the body to a flat plane that's when the bleeding kicks in

OK, I just wanted to be sure you dont mean the visual bleeding.

BleedWhenDying sets in when the NPC has entered the DyingStates (= animations and sounds are played depending on NPCs health, player behavior and chance). The NPC only enters the DyingStates if it is low enough to the ground (HeadValue or something like that - thats the name of the ini value governing this threshold of height).

3 hours ago, HughJanus said:

 

OK, I just wanted to be sure you dont mean the visual bleeding.

BleedWhenDying sets in when the NPC has entered the DyingStates (= animations and sounds are played depending on NPCs health, player behavior and chance). The NPC only enters the DyingStates if it is low enough to the ground (HeadValue or something like that - thats the name of the ini value governing this threshold of height).

There are two values ZValueForHeadBone and ZValueForHeadBone2 it's that it? the first one has the value of 260 and the second one has the value of 3000 what's the difference between those two? It's like a head value and a neck value or is something else?

1 hour ago, ChristianW. said:

There are two values ZValueForHeadBone and ZValueForHeadBone2 it's that it? the first one has the value of 260 and the second one has the value of 3000 what's the difference between those two? It's like a head value and a neck value or is something else?

You need to alter the one with 260. This is the threshold for how low the head bone must go (the second one is the upper cap, so the head bone has to be between the two).

On 4/29/2021 at 3:51 PM, HughJanus said:

 

You need to alter the one with 260. This is the threshold for how low the head bone must go (the second one is the upper cap, so the head bone has to be between the two).

While testing using the Rampage trainer to show the health, I noticed that some npc very rarely spawn with 400 of health and I saw I guess 3 times npc with 800 health, I modified the default health to 155 but even the health when on fire I didn't tweak, I don't notice that much when playing normaly because most of the times they bleed anyway and fall to the ground but it's noticible when the npc is riding a horse for example, but this occuring was very very rare, like If I make a mayhem in town and kill like 100 npc maybe I will see one or two with this crazy amount of health, and I only had seeing npc with 800 points of health in saint denis in my testing, like I said, it's mostly unnoticed when normaly playing but It happen sometimes to show a tank npc that takes far more shoots that it should

On 5/1/2021 at 12:21 PM, ChristianW. said:

While testing using the Rampage trainer to show the health, I noticed that some npc very rarely spawn with 400 of health and I saw I guess 3 times npc with 800 health, I modified the default health to 155 but even the health when on fire I didn't tweak, I don't notice that much when playing normaly because most of the times they bleed anyway and fall to the ground but it's noticible when the npc is riding a horse for example, but this occuring was very very rare, like If I make a mayhem in town and kill like 100 npc maybe I will see one or two with this crazy amount of health, and I only had seeing npc with 800 points of health in saint denis in my testing, like I said, it's mostly unnoticed when normaly playing but It happen sometimes to show a tank npc that takes far more shoots that it should

Does this happen during normal gameplay, a fight or are you playing around with the trainer?

The value 800 is assigned to NPCs who are supposed to survive the burning, while they are on fire (so they dont die). After the burning stops, their health is reset to the normal value. All the other values (400, 155) dont ring any bells.